Update python to 3.12 #887
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to change the run command of the Django container in the docker compose file by the use of local environment variables. This is useful as sometimes the default gunicorn runmode will not properly display errors, this mostly happens for import time errors.
Update python to 3.12 along some dependencies which required updating at the same time.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
- Coverage 92.18% 91.31% -0.87%
==========================================
Files 270 270
Lines 7711 7531 -180
Branches 734 734
==========================================
- Hits 7108 6877 -231
Misses 501 501
- Partials 102 153 +51 ☔ View full report in Codecov by Sentry. |
|
@MythicManiac well code change wise LGTM, did you want me to test this locally? |
|
Not before the obvious issues are fixed (the kombu compatibility issue) at least, since we should do proper testing after the changes are fully locked in, so it'd potentially be wasted work at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update python to 3.12 along some dependencies which required updating at
the same time.
At least a single issue seems to still be unresolved in kombu (used by celery), waiting on celery/kombu#1668 to be resolved before this can be merged